New Adapter: Nativery #4223
New Adapter: Nativery #4223
Conversation
| - video | ||
| - native | ||
| supported-vendors: [] | ||
| vendor-id: 0 |
| - banner | ||
| - video | ||
| - native | ||
| supported-vendors: [] |
There was a problem hiding this comment.
leave it just as supported-vendors:
| BidderDeps nativeryBidderDeps(BidderConfigurationProperties nativeryConfigurationProperties, | ||
| @NotBlank @Value("${external-url}") String externalUrl, | ||
| JacksonMapper mapper) { |
| return mapper.mapper().convertValue(root, ExtRequest.class); | ||
| } | ||
|
|
||
| private boolean isAmpRequest(BidRequest request) { |
There was a problem hiding this comment.
fix the methods order
| for (Imp imp : request.getImp()) { | ||
| try { | ||
| final ExtImpNativery extImp = parseImpExt(imp); | ||
| if (widgetId == null && extImp != null && StringUtils.isNotBlank(extImp.getWidgetId())) { |
There was a problem hiding this comment.
extImp cannot be null at this stage
| final BidRequest singleImpRequest = request.toBuilder() | ||
| .imp(Collections.singletonList(imp)) | ||
| .ext(updatedExt) | ||
| .cur(Collections.singletonList(DEFAULT_CURRENCY)) |
There was a problem hiding this comment.
why is this change needed? I don't this in the Go version
| if (httpCall.getResponse() != null && httpCall.getResponse().getStatusCode() == 204) { | ||
| final MultiMap headers = httpCall.getResponse().getHeaders(); | ||
| final String nativeryErr = headers != null ? headers.get(NATIVERY_ERROR_HEADER) : null; | ||
| if (StringUtils.isNotBlank(nativeryErr)) { | ||
| return Result.withError(BidderError.badInput("Nativery Error: " + nativeryErr + ".")); | ||
| } | ||
| return Result.withError(BidderError.badServerResponse("No Content")); | ||
| } |
There was a problem hiding this comment.
Unfortunately this isn't going to work because the 204 status code is check before calling makeBids in the core, so probably we won't support this weird error-header approach
@CTMBNara what do you think?
|
|
||
| private BidderBid resolveBidderBid(Bid bid, String currency, List<BidderError> errors) { | ||
| try { | ||
| final ObjectNode nativeryExt = extractNativeryExt(bid.getExt()); |
There was a problem hiding this comment.
let's create a separate BidExtNativery object and deserialize with the object mapper, because that manual conversion feels bad
| private ObjectNode extractNativeryExt(ObjectNode bidExt) { | ||
| if (bidExt == null) { | ||
| throw new PreBidException("missing bid.ext"); | ||
| } | ||
| final JsonNode node = bidExt.get("nativery"); | ||
| if (!(node instanceof ObjectNode nativeryNode)) { | ||
| throw new PreBidException("missing bid.ext.nativery"); | ||
| } | ||
| return nativeryNode; | ||
| } |
There was a problem hiding this comment.
Replace with a simple Optional chain
| return Result.of(Collections.emptyList(), errors); | ||
| } | ||
|
|
||
| // 🟢 Zmienione — zamieniamy ExtRequest na ObjectNode |
There was a problem hiding this comment.
please remove the comments
| } | ||
|
|
||
| if (validImps.isEmpty()) { | ||
| return Result.of(Collections.emptyList(), errors); |
There was a problem hiding this comment.
Result.withErrors(errors)
| final ObjectNode originalExt = request.getExt() != null | ||
| ? mapper.mapper().convertValue(request.getExt(), ObjectNode.class) | ||
| : null; |
There was a problem hiding this comment.
it's not necessary to serialize ExtRequest object into the ObjectNode, because ExtRequest is a FlexibleExtension
| final ExtPrebid<?, ExtImpNativery> ext = | ||
| mapper.mapper().convertValue(imp.getExt(), NATIVERY_EXT_TYPE_REFERENCE); | ||
| return ext != null ? ext.getBidder() : null; |
There was a problem hiding this comment.
imp.ext can't be null at this stage, so it can't be deserialized into null
| private ExtRequest buildRequestExtWithNativery(ObjectNode originalExt, boolean isAmp, String widgetId) { | ||
| final ObjectNode root = originalExt != null | ||
| ? originalExt.deepCopy() | ||
| : mapper.mapper().createObjectNode(); | ||
|
|
||
| final ObjectNode nativeryNode = root.with("nativery"); | ||
|
|
||
| nativeryNode.put("isAmp", isAmp); | ||
| if (widgetId != null) { | ||
| nativeryNode.put("widgetId", widgetId); | ||
| } | ||
|
|
||
| return mapper.mapper().convertValue(root, ExtRequest.class); | ||
| } |
There was a problem hiding this comment.
please use ExtRequest and FlexibleExtension capabilities
|
|
||
| private BidderBid resolveBidderBid(Bid bid, String currency, List<BidderError> errors) { | ||
| try { | ||
| final ObjectNode nativeryExt = extractNativeryExt(bid.getExt()); |
| if (httpCall.getResponse() != null && httpCall.getResponse().getStatusCode() == 204) { | ||
| final MultiMap headers = httpCall.getResponse().getHeaders(); | ||
| final String nativeryErr = headers != null ? headers.get(NATIVERY_ERROR_HEADER) : null; | ||
| if (StringUtils.isNotBlank(nativeryErr)) { | ||
| return Result.withError(BidderError.badInput("Nativery Error: " + nativeryErr + ".")); | ||
| } | ||
| return Result.withError(BidderError.badServerResponse("No Content")); | ||
| } |
src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java
Outdated
Show resolved
Hide resolved
| final var response = httpCall.getResponse(); | ||
| if (response == null || StringUtils.isBlank(response.getBody())) { | ||
| return Result.withError(BidderError.badServerResponse("Empty response")); | ||
| } |
| final List<String> advDomains = ListUtils.defaultIfNull( | ||
| nativeryExt.getBidAdvDomains(), Collections.emptyList()); |
There was a problem hiding this comment.
Sorry, I made a typo and recommended the wrong method. Use ListUtils.emptyIfNull() directly.
| private static String mediaTypeString(BidType type) { | ||
| return switch (type) { | ||
| case banner -> type.getName(); | ||
| case video -> type.getName(); | ||
| case xNative -> type.getName(); | ||
| default -> throw new IllegalStateException("Unexpected value: " + type.getName()); | ||
| }; | ||
| } |
There was a problem hiding this comment.
Remove this method and use type.getName instead
| final List<String> safeAdvDomains = Optional.ofNullable(advDomains) | ||
| .orElse(Collections.emptyList()); |
There was a problem hiding this comment.
advDomains can't be null
| @JsonProperty("bid_ad_media_type") | ||
| String bidAdMediaType; | ||
|
|
||
| @JsonProperty("bid_adv_domains") | ||
| List<String> bidAdvDomains; |
There was a problem hiding this comment.
No need for @JsonProperty. Our objectMapper uses snake-case by default
| final ObjectNode extNode = mapper.createObjectNode(); | ||
| extNode.put("accountId", "acc-123"); |
There was a problem hiding this comment.
ObjectNode -> ExtRequest. You can add custom properties to it since it is a FlexibleExtension
| final ObjectNode extNode = mapper.createObjectNode(); | ||
| final ObjectNode prebidNode = mapper.createObjectNode(); | ||
| final ObjectNode serverNode = mapper.createObjectNode(); | ||
| serverNode.put("endpoint", Endpoint.openrtb2_amp.value()); | ||
| prebidNode.set("server", serverNode); | ||
| extNode.set("prebid", prebidNode); |
🔧 Type of changes
✨ What's the context?
#4198